Closed Bug 1685566 Opened 4 years ago Closed 4 years ago

two profiles, nightly works but messages are misleading

Categories

(Toolkit :: Application Update, defect)

Firefox 86
x86_64
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1480452

People

(Reporter: pzz, Unassigned)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

Launch nightly, it updates itself, leave it up.
Launch profile manager (-P), select and launch a second profile.
First profile remains up, nightly updates itself again, second profile comes up.
Continue browsing.

Actual results:

At some point later a window in the first profile says something like sorry we just need to do one little thing...
Press the presented button to relaunch firefox.
Second profile remains up, first profile disappears, nothing further happens.
Relaunch profile manager, reselect and relaunch first profile, it comes up.

Expected results:

it works fine except that the "sorry we just need..." message and the presented relaunch button are misleading.

Or conversely you could say while a profile is still up it shouldn't update itself again yet. Either way.

this is interesting. today i see, in place of the dialog that normally would invite me to restart firefox to launch the updated version, "Nightly is unable to automatically update to the latest version...A new Nightly update is available, but it can't be installed because another copy of Nightly is running. Close it to continue the update, or choose to update anyway (the other copy may not work correctly until you restart it)...Not Now...Update Nightly anyway"

well maybe this bug has just been fixed already, tho i'm more inclined to expect that there are indeed already checks that try to implement comment 1, but this bug represents evidence of a pathway that slips by without being checked.

Hi,

Thanks for reporting this. I wasn't able to reproduce since i'm not able to update nightly at all (may be due to https://bugzilla.mozilla.org/show_bug.cgi?id=1686708)

Setting a component for this in order to get the dev team involved.
(If the team feels it's an incorrect one please feel free to change it to a more appropriate one.)

Best,
Clara

Component: Untriaged → Application Update
Product: Firefox → Toolkit

Hello. That indeed does not sound like the right behavior. We can look into it further if you can provide some logs. On both profiles, could you navigate to about:config and set the pref app.update.log to true? This may not take effect until you restart the browser due to Bug 1683436.

Then, when you experience the issue again, open the browser console (Control+Shift+J, or Hamburger Menu->Web Developer->Browser Console), set the filter to AUS:SVC, and attach the resulting messages to this bug. Ideally, we would like the logs from both profiles' browsers. Please let us know when you post each log whether it was from the browser instance that showed the notification, or whether it was from the browser instance that didn't show the notification.

Thanks!

Flags: needinfo?(bugzillamozilla)

Closing this out due to inactivity. Please re-open if this happens again, and we'll keep digging.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
i've been waiting, but neither the description in the OP nor in comment 2 has occurred in awhile now. Today i didn't launch the second profile until hours after the first, and sure enough as the second profile came up Nightly updated itself again. Now both have been up for hours. As the second profile updated Nightly again, i would expect to see a message saying i better relaunch the first profile again or something like that, but there have been no messages about anything. But there have been a couple anomalies.. i participated in a meet.jit.si meeting today. When i joined the meeting with the first profile, other participants couldn't hear or see me even tho jit.si was indicating that my camera and microphone were working. So i joined the meeting with my second profile, and that worked fine. And just now i tried to go to an okcupid.com page with both profiles. The first profile just got stuck waiting on google.com (for ads maybe?), the second profile brought the page right up. i just set both profile browser console filters to AUS:SVC, in the first profile console all 73 messages are hidden, in the second profile console all 4 messages are hidden. After clearing the filters, the second console shows: UTM:SVC TimerManager:notify - fire timerID: browser-cleanup-thumbnails intended time: 1613519205 (2021-02-16T23:46:45.000Z) UTM:SVC TimerManager:notify - notified timerID: browser-cleanup-thumbnails [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692" data: no] L10nRegistry.jsm:692:19 Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content. And the first console shows:

And the first console shows...(see attachment at head of prior comment)

...and messages are still accumulating, perhaps due to activity in my gmail account, which is still up in the first profile and apparently working.

i just reloaded the gmail page and the message count jumped up to 267. the gmail page seems fine.

Status: RESOLVED → UNCONFIRMED
Flags: needinfo?(bugzillamozilla)
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Resolution: INACTIVE → ---

So i guess the thing for me to learn is whenever one profile updates Nightly, the other profile ought to be relaunched. Even if, as in the OP, it was brought up only minutes ago.

As reported in comment 2 i did once see a message implying i ought to relaunch the other profile, but i've not seen any such message again since.

So...i go to relaunch the first profile...When it thinks i ought to relaunch, that option is available on the menu, but no such option is there right now, looks like my only option is to "quit".

As it happens, i just walked away from it yesterday without quitting anything, came back this morning and tried to load a page in the first profile, and now it tells me

"Sorry. We just need to do one small thing to keep going.

Nightly has just been updated in the background. Click Restart Nightly to complete the update.

We will restore all your pages, windows and tabs afterwards, so you can be on your way quickly...Restart Nightly[button]"

Tho according to my experience in the OP i expect pressing the displayed "Restart Nightly" button will effectively just quit the first profile.

...and indeed it did. So now i'll relaunched the first profile, and in the process of coming up i expect it may update Nightly again, and so i expect the problem will then leapfrog so the second profile will be behind the 8 ball. So i'll submit this comment as is for now...

ok the second profile is still up and the first profile is relaunched. At this point when i apply the AUS:SVC filter in both browser consoles, in the first (freshly relaunched) profile 61 messages are hidden and none remain, and in the second (still up) profile 24 are hidden and these messages remain:

24 hidden
AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml 3
AUS:SVC Checker:checkForUpdates - sending request to: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml
AUS:SVC Checker: checkForUpdates: check request already active, aborting 2
AUS:SVC Checker:onLoad - request completed downloading document
AUS:SVC Checker:onLoad - Getting sslStatus failed.
AUS:SVC Checker:onLoad - number of updates available: 1
AUS:SVC getCanApplyUpdates - testing write access /b/fu/opt/firefox/update.test
AUS:SVC shouldUseService - returning false
AUS:SVC getCanApplyUpdates - able to apply updates
AUS:SVC UpdateService:_selectAndInstallUpdate - download the update
AUS:SVC UpdateService:downloadUpdate - not downloading update because the update that's already been downloaded is the same version or newer.
currently downloaded update application version: 87.0a1
available update application version : 87.0a1
currently downloaded update build ID: 20210216215129
available update build ID : 20210216215129
AUS:SVC readStatusFile - status: pending, path: /b/fu/opt/firefox/updates/0/update.status 2
AUS:SVC getCanApplyUpdates - testing write access /b/fu/opt/firefox/update.test
AUS:SVC shouldUseService - returning false
AUS:SVC getCanApplyUpdates - able to apply updates
AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml
AUS:SVC Checker: checkForUpdates, force: false
AUS:SVC UpdateService.canCheckForUpdates - another instance is holding the lock, will need to wait for it prior to checking for updates
AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
AUS:SVC waitForOtherInstances - beginning polling
AUS:SVC getCanApplyUpdates - testing write access /b/fu/opt/firefox/update.test
AUS:SVC shouldUseService - returning false
AUS:SVC getCanApplyUpdates - able to apply updates
AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml
AUS:SVC Checker: checkForUpdates, force: false
AUS:SVC UpdateService.canCheckForUpdates - another instance is holding the lock, will need to wait for it prior to checking for updates
AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
AUS:SVC getCanApplyUpdates - testing write access /b/fu/opt/firefox/update.test
AUS:SVC shouldUseService - returning false
AUS:SVC getCanApplyUpdates - able to apply updates
AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml
AUS:SVC Checker: checkForUpdates, force: false
AUS:SVC UpdateService.canCheckForUpdates - another instance is holding the lock, will need to wait for it prior to checking for updates
AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
AUS:SVC waitForOtherInstances - no other instances found, exiting
AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml 3
AUS:SVC Checker:checkForUpdates - sending request to: https://aus5.mozilla.org/update/6/Firefox/87.0a1/20210216094005/Linux_x86_64-gcc3/en-US/nightly/Linux%205.4.0-60-generic%20(GTK%203.24.20%2Clibpulse%2013.99.0)/ISET:SSE4_2,MEM:7680/default/default/update.xml
AUS:SVC Checker: checkForUpdates: check request already active, aborting 2
AUS:SVC Checker:onLoad - request completed downloading document
AUS:SVC Checker:onLoad - Getting sslStatus failed.
AUS:SVC Checker:onLoad - number of updates available: 1
AUS:SVC getCanApplyUpdates - testing write access /b/fu/opt/firefox/update.test
AUS:SVC shouldUseService - returning false
AUS:SVC getCanApplyUpdates - able to apply updates
AUS:SVC UpdateService:_selectAndInstallUpdate - download the update
AUS:SVC Creating Downloader
AUS:SVC UpdateService:_downloadUpdate
AUS:SVC getCanUseBits - Not using BITS because this is not Windows
AUS:SVC Downloader:downloadUpdate - Starting nsIIncrementalDownload with url: https://archive.mozilla.org/pub/firefox/nightly/partials/2021/02/2021-02-17-09-45-59-mozilla-central/firefox-mozilla-central-87.0a1-linux-x86_64-en-US-20210216094005-20210217094559.partial.mar, path: /b/fu/opt/firefox/updates/downloading/update.mar, interval: 0
AUS:SVC Downloader:onStartRequest - original URI spec: https://archive.mozilla.org/pub/firefox/nightly/partials/2021/02/2021-02-17-09-45-59-mozilla-central/firefox-mozilla-central-87.0a1-linux-x86_64-en-US-20210216094005-20210217094559.partial.mar, final URI spec: https://archive.mozilla.org/pub/firefox/nightly/partials/2021/02/2021-02-17-09-45-59-mozilla-central/firefox-mozilla-central-87.0a1-linux-x86_64-en-US-20210216094005-20210217094559.partial.mar
AUS:SVC Downloader:onProgress - progress: 32768/10972473
AUS:SVC Downloader:onProgress - progress: 424702/10972473
AUS:SVC Downloader:onProgress - progress: 1194750/10972473
AUS:SVC Downloader:onProgress - progress: 2079486/10972473
AUS:SVC Downloader:onProgress - progress: 2783998/10972473
AUS:SVC Downloader:onProgress - progress: 3717886/10972473
AUS:SVC Downloader:onProgress - progress: 4471550/10972473
AUS:SVC Downloader:onProgress - progress: 5061374/10972473
AUS:SVC Downloader:onProgress - progress: 5995262/10972473
AUS:SVC Downloader:onProgress - progress: 6754694/10972473
AUS:SVC Downloader:onProgress - progress: 7377286/10972473
AUS:SVC Downloader:onProgress - progress: 8307246/10972473
AUS:SVC Downloader:onProgress - progress: 9060910/10972473
AUS:SVC Downloader:onProgress - progress: 9683502/10972473
AUS:SVC Downloader:onProgress - progress: 10661838/10972473
AUS:SVC Downloader:onProgress - progress: 10972473/10972473
AUS:SVC Downloader:onStopRequest - downloader: nsIIncrementalDownload, original URI spec: https://archive.mozilla.org/pub/firefox/nightly/partials/2021/02/2021-02-17-09-45-59-mozilla-central/firefox-mozilla-central-87.0a1-linux-x86_64-en-US-20210216094005-20210217094559.partial.mar, final URI spec: https://archive.mozilla.org/pub/firefox/nightly/partials/2021/02/2021-02-17-09-45-59-mozilla-central/firefox-mozilla-central-87.0a1-linux-x86_64-en-US-20210216094005-20210217094559.partial.mar, status: 0
AUS:SVC Downloader:onStopRequest - status: 0, current fail: 0, max fail: 10, retryTimeout: 2000
AUS:SVC Downloader:_verifyDownload called
AUS:SVC Downloader:_verifyDownload downloaded size == expected size.
AUS:SVC shouldUseService - returning false
AUS:SVC Downloader:onStopRequest - setting state to: pending
AUS:SVC promiseLangPacksUpdated - waiting for language pack updates to stage.
AUS:SVC Downloader:onStopRequest - Notifying observers that an update was downloaded. topic: update-downloaded, status: pending

And now the (still up) second profile is giving me the same message as in comment 2. That's fair enough behavior.

The first bug, it seems to me, is that when launching a second profile, it doesn't take note there's another profile already up. i would think it should notice, and refrain from updating. That should prevent the OP situation from happening.

But then secondarily, if somehow an update happens anyway when two profiles are up and thus the OP message gets triggered, it ought to be rewritten to warn what's really about to happen.

(In reply to gregrwm from comment #12)

The first bug, it seems to me, is that when launching a second profile, it doesn't take note there's another profile already up. i would think it should notice, and refrain from updating. That should prevent the OP situation from happening.

This sounds like bug 1480452, then. I'm going to close this as a duplicate unless you think there's something else to consider here (besides the second point below).

But then secondarily, if somehow an update happens anyway when two profiles are up and thus the OP message gets triggered, it ought to be rewritten to warn what's really about to happen.

There is some effort made to prevent this now in bug 1553982, so that when two Firefox instances are running at the same time neither will try to update, that's the message you saw in comment 2.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: